Refactor converting ODK XML to OSM XML #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… return data types
…select_multiple support
|
Conflicts must be resolved before merge 👍 |
for more information, see https://pre-commit.ci
|
Major refactoring. The format parsers for CSV, JSON, or XML are now in a single class, so next several files can be deleted. This reduces code duplication, and improves maintenance. Now the odk2osm.py script takes any of the 3 support formats instead of separate scripts. |
spwoodcock
approved these changes
Jun 15, 2024
| @@ -50,6 +49,7 @@ def __init__( | |||
| """ | |||
| self.data = data | |||
| self.filespec = filespec | |||
| self.ignore = ["today", "start", "deviceid", "nodel", "instanceID"] | |||
There was a problem hiding this comment.
ODKInstance.py is about to be deleted, as now parsers.py is used instead. Also now the tags to ignore are in the xforms.yaml file.
There was a problem hiding this comment.
well, json2osm.py is about to be deleted, now odk2osm.py handles all 3 formats from ODK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for converting the raw ODK XML instance files to OSM has not kept up with other improvements in the conversion process. This brings odk2osm.py in sync with the other conversion utilities, while also adding support for select_multiple.